Fix Issue 886: VB -> C# wrong conversion of optional struct or decimal ref parameter#1238
Fix Issue 886: VB -> C# wrong conversion of optional struct or decimal ref parameter#1238GrahamTheCoder wants to merge 1 commit intomasterfrom
Conversation
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
| var literalValue = literalExpr.Token.Value; | ||
| if (literalValue is decimal decimalVal) { | ||
| var isInteger = decimalVal == Math.Round(decimalVal); | ||
| var newLiteral = isInteger ? CommonConversions.Literal((int)decimalVal) : CommonConversions.Literal((double)decimalVal); |
There was a problem hiding this comment.
Seems a bit risky to cast decimal to double if someone really did need the last half of the precision. We should add a condition to check if the number round trips and error otherwise
1 participant
This PR fixes an issue where converting
Optional ByRefVB.NET parameters initialized withNothingfor custom structures or numericDecimaldefaults emitted C# code that fails to compile due to C# compiler limitations with[DefaultParameterValue].Changes:
ExpressionNodeVisitor.cs: For[DefaultParameterValue],decimalparameter primitive defaults now properly emit an equivalent constantintordoublevalid attribute expression, without the decimalmsuffix which is disallowed. For generic structs (TypeKind.StructandSpecialType.None), noDefaultParameterValueattribute will be generated as custom structs with non-null defaults fail natively on C#.ArgumentConverter.cs: Whenever default parameters expand for variable definitions around callers (refarguments), non-nullable structs initialized tonullinstead will yield their expecteddefaultinitialization.OptionalByRefParameterAsync886and verified it passes correctly alongside all project suites.PR created automatically by Jules for task 15338263271799288852 started by @GrahamTheCoder